ctx = ngx_http_get_module_ctx(r, ngx_http_lua_module); ctx 为空

helloworld0118 · 2017-07-12T10:34:25+00:00

Hi folks, OpenResty 1.11.2.4 is just released to include the latest nginx security fix in its range filter module (CVE-2017-7529). You can download this ve...

ctx = ngx_http_get_module_ctx(r, ngx_http_lua_module); ctx 为空

helloworld0118

static void

ngx_http_lua_socket_handle_read_error(ngx_http_request_t *r,

ngx_http_lua_socket_tcp_upstream_t *u, ngx_uint_t ft_type)

{

ngx_http_lua_ctx_t *ctx;

ngx_http_lua_co_ctx_t *coctx;

ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,

"lua tcp socket handle read error");

u->ft_type |= ft_type;

#if 0

ngx_http_lua_socket_tcp_finalize(r, u);

#endif

u->read_event_handler = ngx_http_lua_socket_dummy_handler;

if (u->read_waiting) {

u->read_waiting = 0;

coctx = u->read_co_ctx;

coctx->cleanup = NULL;

u->read_co_ctx = NULL;

ctx = ngx_http_get_module_ctx(r, ngx_http_lua_module); // 这里ctx 为空导致 core dump 有人遇到过这种情况吗？

ctx->resume_handler = ngx_http_lua_socket_tcp_read_resume;

ctx->cur_co_ctx = coctx;

ngx_http_lua_assert(coctx && (!ngx_http_lua_is_thread(ctx)

|| coctx->co_ref >= 0));

ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,

"lua tcp socket waking up the current request");

r->write_event_handler(r);

}

zchao1995

复现场景是怎么样的？

On Wednesday, July 12, 2017 at 10:34:25 AM UTC+8, hello world wrote:

static void
ngx_http_lua_socket_handle_read_error(ngx_http_request_t *r,
ngx_http_lua_socket_tcp_upstream_t *u, ngx_uint_t ft_type)
{
ngx_http_lua_ctx_t *ctx;
ngx_http_lua_co_ctx_t *coctx;

ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"lua tcp socket handle read error");

u->ft_type |= ft_type;

#if 0
ngx_http_lua_socket_tcp_finalize(r, u);
#endif

u->read_event_handler = ngx_http_lua_socket_dummy_handler;

if (u->read_waiting) {
u->read_waiting = 0;

coctx = u->read_co_ctx;
coctx->cleanup = NULL;
u->read_co_ctx = NULL;

ctx = ngx_http_get_module_ctx(r, ngx_http_lua_module); // 这里ctx 为空导致 core dump 有人遇到过这种情况吗？

ctx->resume_handler = ngx_http_lua_socket_tcp_read_resume;
ctx->cur_co_ctx = coctx;

ngx_http_lua_assert(coctx && (!ngx_http_lua_is_thread(ctx)
|| coctx->co_ref >= 0));

ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"lua tcp socket waking up the current request");

r->write_event_handler(r);
}
}

helloworld0118

正常的环境，没有什么特殊，有其他设备和A设备配置各方面都一致，但就A设备出问题。现在想法只能修改代码，来修复ctx 为空的core dump了

在 2017年7月12日星期三 UTC+8下午7:57:55，tokers写道：

复现场景是怎么样的？

On Wednesday, July 12, 2017 at 10:34:25 AM UTC+8, hello world wrote:
static void
ngx_http_lua_socket_handle_read_error(ngx_http_request_t *r,
ngx_http_lua_socket_tcp_upstream_t *u, ngx_uint_t ft_type)
{
ngx_http_lua_ctx_t *ctx;
ngx_http_lua_co_ctx_t *coctx;

ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"lua tcp socket handle read error");

u->ft_type |= ft_type;

#if 0
ngx_http_lua_socket_tcp_finalize(r, u);
#endif

u->read_event_handler = ngx_http_lua_socket_dummy_handler;

if (u->read_waiting) {
u->read_waiting = 0;

coctx = u->read_co_ctx;
coctx->cleanup = NULL;
u->read_co_ctx = NULL;

ctx = ngx_http_get_module_ctx(r, ngx_http_lua_module); // 这里ctx 为空导致 core dump 有人遇到过这种情况吗？

ctx->resume_handler = ngx_http_lua_socket_tcp_read_resume;
ctx->cur_co_ctx = coctx;

ngx_http_lua_assert(coctx && (!ngx_http_lua_is_thread(ctx)
|| coctx->co_ref >= 0));

ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"lua tcp socket waking up the current request");

r->write_event_handler(r);
}
}

helloworld0118

if (ctx == NULL) {

return;

}

我加了一个判断，我瞧其他地方在用的ctx 时有做这个判断，这样就好了，目前没有发现其他问题。

在 2017年7月12日星期三 UTC+8下午7:57:55，tokers写道：

复现场景是怎么样的？

On Wednesday, July 12, 2017 at 10:34:25 AM UTC+8, hello world wrote:
static void
ngx_http_lua_socket_handle_read_error(ngx_http_request_t *r,
ngx_http_lua_socket_tcp_upstream_t *u, ngx_uint_t ft_type)
{
ngx_http_lua_ctx_t *ctx;
ngx_http_lua_co_ctx_t *coctx;

ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"lua tcp socket handle read error");

u->ft_type |= ft_type;

#if 0
ngx_http_lua_socket_tcp_finalize(r, u);
#endif

u->read_event_handler = ngx_http_lua_socket_dummy_handler;

if (u->read_waiting) {
u->read_waiting = 0;

coctx = u->read_co_ctx;
coctx->cleanup = NULL;
u->read_co_ctx = NULL;

ctx = ngx_http_get_module_ctx(r, ngx_http_lua_module); // 这里ctx 为空导致 core dump 有人遇到过这种情况吗？

ctx->resume_handler = ngx_http_lua_socket_tcp_read_resume;
ctx->cur_co_ctx = coctx;

ngx_http_lua_assert(coctx && (!ngx_http_lua_is_thread(ctx)
|| coctx->co_ref >= 0));

ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"lua tcp socket waking up the current request");

r->write_event_handler(r);
}
}