headers-more-nginx-module

info · 2013-12-22T03:42:37+00:00

Hello! On Wed, Oct 10, 2012 at 12:31 AM, T T wrote: > I am trying to match a "Content-Type: text/html; charset=utf-8" > > more_set_header...

headers-more-nginx-module

info

/src/ngx_http_headers_more_headers_out.c(182) : warning C4307: '*' : integral constant overflow

Another;
        r->headers_out.location->hash =
            ngx_hash(ngx_hash(ngx_hash(ngx_hash(ngx_hash(ngx_hash(
                       ngx_hash('l', 'o'), 'c'), 'a'), 't'), 'i'), 'o'), 'n');

:)

Tried to nick code from lua but can't figure out in https://github.com/chaoslawful/lua-nginx-module/commit/c6b6b31 how to rewrite

ngx_http_lua_location_hash

agentzh

Hello!

On Sat, Dec 21, 2013 at 11:42 AM,  <i...@ecsystems.nl> wrote:
> /src/ngx_http_headers_more_headers_out.c(182) : warning C4307: '*' :
> integral constant overflow
>

Just committed a patch to master to fix this warning from the
Microsoft compiler :)

    https://github.com/agentzh/headers-more-nginx-module/commit/40414ca

Thanks for the report!

Best regards,
-agentzh

info

I've seen the commits but no fix for;
/src/ngx_http_headers_more_headers_out.c(184) : warning C4307: '*' : integral constant overflow
The "ngx_hash(ngx_hash(ngx_hash(..." is still there though it moved 2 lines down :)

On Sunday, December 22, 2013 4:00:11 AM UTC+1, agentzh wrote:

Hello!

On Sat, Dec 21, 2013 at 11:42 AM, <in...@ecsystems.nl> wrote:
> /src/ngx_http_headers_more_headers_out.c(182) : warning C4307: '*' :
> integral constant overflow
>

Just committed a patch to master to fix this warning from the
Microsoft compiler :)

https://github.com/agentzh/headers-more-nginx-module/commit/40414ca

Thanks for the report!

Best regards,
-agentzh

agentzh

Hello!

On Sun, Dec 22, 2013 at 4:07 AM,  <i...@ecsystems.nl> wrote:
> I've seen the commits but no fix for;
> /src/ngx_http_headers_more_headers_out.c(184) : warning C4307: '*' :
> integral constant overflow
> The "ngx_hash(ngx_hash(ngx_hash(..." is still there though it moved 2 lines
> down :)
>

Oh, my mistake. I defined the ngx_http_headers_more_location_hash
thing but forgot to actually use it. Sigh.

Just committed a fix for this:

    https://github.com/agentzh/headers-more-nginx-module/commit/6e9dd00

Please try it again :)

Thanks!
-agentzh

info

Heya, it works ! tnx!

On Sunday, December 22, 2013 7:19:57 PM UTC+1, agentzh wrote:

Hello!

Oh, my mistake. I defined the ngx_http_headers_more_location_hash
thing but forgot to actually use it. Sigh.