Nginx Lua adds the Content-Type header to responses

aviram · 2013-06-05T19:32:43+00:00

Great I will check it out. Thanks. On 6/4/13 11:57 AM, Oleksiy Kovyrin wrote:...

Nginx Lua adds the Content-Type header to responses

aviram

Hi,

I'm implementing a proxy using Nginx and Nginx-Lua.

When the remote server (to which I'm proxying) sends a response without a "Content-Type" header, the Nginx-Lua module adds it (and sets its value to the default Nginx type).

When a browser receives a response with no "Content-Type" header, it assumes that it is "text/html", while the default Nginx type is usually "application/octet-stream".

In such cases, the addition of the header would causes the browsers to download the HTML files and not to load them.

Viewing (and debugging) the code, I've notice that this happens in two places in the code - the function ngx_http_lua_ngx_header_set and the function ngx_http_lua_send_header_if_needed. Removing these lines solves the problem...

Why is there an addition of the "Content-Type" header in the response headers if it is not set? If there is a good reason, is it okay to add a configuration directive stating whether or not we want to set this field?

I'll be happy to post a patch (or a pull request) :-)

Regards

Aviram

david

Why not simply set the default content type to text/html

if thats what the browser is expecting anyway?



On 6/5/13 7:32 AM, av...@adallom.com wrote:

Hi,

I'm implementing a proxy using Nginx and Nginx-Lua.
When the remote server (to which I'm proxying) sends a responsewithout a "Content-Type" header, the Nginx-Lua module adds it (andsets its value to the default Nginx type).
When a browser receives a response with no "Content-Type" header, itassumes that it is "text/html", while the default Nginx type isusually "application/octet-stream".In such cases, the addition of the header would causes the browsers todownload the HTML files and not to load them.
Viewing (and debugging) the code, I've notice that this happens in twoplaces in the code - the function ngx_http_lua_ngx_header_set and thefunction ngx_http_lua_send_header_if_needed. Removing these linessolves the problem...
Why is there an addition of the "Content-Type" header in the responseheaders if it is not set? If there is a good reason, is it okay to adda configuration directive stating whether or not we want to set thisfield?
I'll be happy to post a patch (or a pull request) :-)

Regards
Aviram

--
.

aviram

That may cause Nginx issues, of the Nginx server treating stuff as "text/html" when they should be "application/octet-stream"...

On Wednesday, June 5, 2013 2:35:40 PM UTC+3, David wrote:

Why not simply set the default content type to text/html

if thats what the browser is expecting anyway?

On 6/5/13 7:32 AM, avi...@adallom.com wrote:
> Hi,
>
> I'm implementing a proxy using Nginx and Nginx-Lua.
> When the remote server (to which I'm proxying) sends a response
> without a "Content-Type" header, the Nginx-Lua module adds it (and
> sets its value to the default Nginx type).
>
> When a browser receives a response with no "Content-Type" header, it
> assumes that it is "text/html", while the default Nginx type is
> usually "application/octet-stream".
> In such cases, the addition of the header would causes the browsers to
> download the HTML files and not to load them.
>
> Viewing (and debugging) the code, I've notice that this happens in two
> places in the code - the function ngx_http_lua_ngx_header_set and the
> function ngx_http_lua_send_header_if_needed. Removing these lines
> solves the problem...
>
> Why is there an addition of the "Content-Type" header in the response
> headers if it is not set? If there is a good reason, is it okay to add
> a configuration directive stating whether or not we want to set this
> field?
>
> I'll be happy to post a patch (or a pull request) :-)
>
> Regards
> Aviram.
>
>

david

I see. But cant you isolate that to your context? Seems it would not be a nginx global setting. Just the default for cases when you dont have content/type header.

On 6/5/13 7:43 AM, av...@adallom.com wrote:

That may cause Nginx issues, of the Nginx server treating stuff as "text/html" when they should be "application/octet-stream"...

On Wednesday, June 5, 2013 2:35:40 PM UTC+3, David wrote:
Why not simply set the default content type to text/html

if thats what the browser is expecting anyway?

On 6/5/13 7:32 AM, avi...@adallom.com wrote:
> Hi,
>
> I'm implementing a proxy using Nginx and Nginx-Lua.
> When the remote server (to which I'm proxying) sends a response
> without a "Content-Type" header, the Nginx-Lua module adds it (and
> sets its value to the default Nginx type).
>
> When a browser receives a response with no "Content-Type" header, it
> assumes that it is "text/html", while the default Nginx type is
> usually "application/octet-stream".
> In such cases, the addition of the header would causes the browsers to
> download the HTML files and not to load them.
>
> Viewing (and debugging) the code, I've notice that this happens in two
> places in the code - the function ngx_http_lua_ngx_header_set and the
> function ngx_http_lua_send_header_if_needed. Removing these lines
> solves the problem...
>
> Why is there an addition of the "Content-Type" header in the response
> headers if it is not set? If there is a good reason, is it okay to add
> a configuration directive stating whether or not we want to set this
> field?
>
> I'll be happy to post a patch (or a pull request) :-)
>
> Regards
> Aviram.

agentzh

Hello!

On Wed, Jun 5, 2013 at 6:32 AM,  aviram wrote:
> I'm implementing a proxy using Nginx and Nginx-Lua.
> When the remote server (to which I'm proxying) sends a response without a
> "Content-Type" header, the Nginx-Lua module adds it (and sets its value to
> the default Nginx type).
>

Yes, this is the intended behavior of ngx_lua. Maybe we could add an
nginx directive to disable this functionality? Patches welcome :)

Also, as suggested by David, you can just configure the default_type
directive to "text/html" in your specific location blocks.

Best regards,
-agentzh

agentzh

Hello!

On Fri, Jun 7, 2013 at 12:00 PM, agentzh wrote:
> On Wed, Jun 5, 2013 at 6:32 AM,  aviram wrote:
>> I'm implementing a proxy using Nginx and Nginx-Lua.
>> When the remote server (to which I'm proxying) sends a response without a
>> "Content-Type" header, the Nginx-Lua module adds it (and sets its value to
>> the default Nginx type).
>
> Yes, this is the intended behavior of ngx_lua. Maybe we could add an
> nginx directive to disable this functionality? Patches welcome :)
>

Just for the record, the following directive can be used to control this:

    https://github.com/openresty/lua-nginx-module#lua_use_default_type

Regards,
-agentzh