latest nginx changes causes error in ngx_http_lua_socket_tcp.c

info · 2013-12-14T16:01:42+00:00

Hello! On Wed, Dec 11, 2013 at 8:05 PM, caquino wrote: > Someone knows if it's possible to return a 206 Partial content using > ngx.exit? > It wo...

latest nginx changes causes error in ngx_http_lua_socket_tcp.c

info

While back porting nginx changes by Ruslan Ermilov I get this error:

/src/ngx_http_lua_socket_tcp.c(558) : error C2039: 'type' : is not a member of 'ngx_resolver_ctx_s'
src/core\ngx_resolver.h(141) : see declaration of 'ngx_resolver_ctx_s'
/src/ngx_http_lua_socket_tcp.c(743) : error C2440: '=' : cannot convert from 'ngx_addr_t' to 'ULONG'

agentzh

Hello!

On Sat, Dec 14, 2013 at 12:01 AM,  <i...@ecsystems.nl> wrote:
> While back porting nginx changes by Ruslan Ermilov I get this error:
>
> /src/ngx_http_lua_socket_tcp.c(558) : error C2039: 'type' : is not a member
> of 'ngx_resolver_ctx_s'
>         src/core\ngx_resolver.h(141) : see declaration of
> 'ngx_resolver_ctx_s'
> /src/ngx_http_lua_socket_tcp.c(743) : error C2440: '=' : cannot convert from
> 'ngx_addr_t' to 'ULONG'
>

Yes, Ruslan Ermilov changed the resolver API in the hg repos for Nginx
and broke backward compatibility here.

I just wrote the following patch to make ngx_lua compile with the
latest hg version of nginx:

    http://openresty.org/download/ngx-lua-for-nginx-1.5.8.patch

Note that I haven't done much testing with this version of nginx
because nginx 1.5.8 is not out yet. You can test it yourself anyway :)

Regards,
-agentzh

info

I just wrote the following patch to make ngx_lua compile with the
latest hg version of nginx:

http://openresty.org/download/ngx-lua-for-nginx-1.5.8.patch

Can you publish the full file? I don't use hg.

Note that I haven't done much testing with this version of nginx
because nginx 1.5.8 is not out yet. You can test it yourself anyway :)

nginx-win lives on the bleeding edge running 1 day behind mainline development.

agentzh

Hello!

On Sat, Dec 14, 2013 at 1:43 PM,  <i...@ecsystems.nl> wrote:
>> I just wrote the following patch to make ngx_lua compile with the
>> latest hg version of nginx:
>>
>>     http://openresty.org/download/ngx-lua-for-nginx-1.5.8.patch
>>
>
> Can you publish the full file? I don't use hg.
>

No, this patch is not specific to hg and it was not generated by hg either.

You can apply this patch to ngx_lua's source tree by the "patch"
command-line utility (or something like that). You can get the Win32
version of the "patch" from GnuWin32, for example.

I don't like to burden to publish whole source files. There are
actually two source files involved in this patch.

>>
>> Note that I haven't done much testing with this version of nginx
>> because nginx 1.5.8 is not out yet. You can test it yourself anyway :)
>
> nginx-win lives on the bleeding edge running 1 day behind mainline
> development.
>

Well, then you'll have to deal with various API incompatibility
changes as soon as possible. I'm not sure if I can always respond that
fast. Also, the Nginx team MAY change their mind before the release.
So...be prepared :)

Regards,
-agentzh

info

On Saturday, December 14, 2013 11:05:23 PM UTC+1, agentzh wrote:

Well, then you'll have to deal with various API incompatibility
changes as soon as possible. I'm not sure if I can always respond that
fast. Also, the Nginx team MAY change their mind before the release.
So...be prepared :)

It not just Lua they broke but a whole bunch of others as well, I'll have a deeper look and may trow out this api change or duplicate to support both.
But your fast response is appreciated :)

info

Heya, Fyi. the latest master compiles fine for 157, 158 and 159 (resolver api new and old).

fast. Also, the Nginx team MAY change their mind before the release.
So...be prepared :)

Regards,
-agentzh

agentzh

Hello!

On Thu, Dec 19, 2013 at 1:46 PM,  info wrote:
> Heya, Fyi. the latest master compiles fine for 157, 158 and 159 (resolver
> api new and old).
>

Cool. Thank you for the feedback :)

Best regards,
-agentzh