encrypted-session-nginx-module

info · 2014-02-08T03:42:17+00:00

I'll grab that patch and give it a try.Soon, I hope...

encrypted-session-nginx-module

info

Heya agentzh, hopefully you have a few minutes to fix these warnings :)

/encrypted-session-nginx-module/src/ngx_http_encrypted_session_module.c(45) : warning C4152: nonstandard extension, function/data pointer conversion in _expression_
/encrypted-session-nginx-module/src/ngx_http_encrypted_session_module.c(52) : warning C4152: nonstandard extension, function/data pointer conversion in _expression_
/encrypted-session-nginx-module/src/ngx_http_encrypted_session_module.c(166) : warning C4244: 'function' : conversion from 'time_t' to 'ngx_uint_t', possible loss of data

info

Oops, forgot a few more...

/src/ngx_http_encrypted_session_cipher.c(10) : warning C4431: missing type specifier - int assumed. Note: C no longer supports default-int
/src/ngx_http_encrypted_session_cipher.c(10) : error C2054: expected '(' to follow 'inline'
/src/ngx_http_encrypted_session_cipher.c(10) : error C2085: 'ngx_http_encrypted_session_ntohll' : not in formal parameter list
/src/ngx_http_encrypted_session_cipher.c(11) : error C2082: redefinition of formal parameter 'inline'
/src/ngx_http_encrypted_session_cipher.c(11) : error C2146: syntax error : missing ',' before identifier 'uint64_t'
/src/ngx_http_encrypted_session_cipher.c(11) : error C2146: syntax error : missing ',' before identifier 'ngx_http_encrypted_session_htonll'
/src/ngx_http_encrypted_session_cipher.c(11) : error C2143: syntax error : missing ';' before '('
/src/ngx_http_encrypted_session_cipher.c(11) : error C2059: syntax error : ')'
/src/ngx_http_encrypted_session_cipher.c(71) : warning C4013: 'ngx_http_encrypted_session_htonll' undefined; assuming extern returning int
/src/ngx_http_encrypted_session_cipher.c(226) : warning C4013: 'ngx_http_encrypted_session_ntohll' undefined; assuming extern returning int
/src/ngx_http_encrypted_session_cipher.c(258) : warning C4431: missing type specifier - int assumed. Note: C no longer supports default-int
/src/ngx_http_encrypted_session_cipher.c(258) : error C2054: expected '(' to follow 'inline'
/src/ngx_http_encrypted_session_cipher.c(258) : error C2082: redefinition of formal parameter 'ngx_http_encrypted_session_ntohll'
/src/ngx_http_encrypted_session_cipher.c(258) : error C2143: syntax error : missing ';' before '{'
/src/ngx_http_encrypted_session_cipher.c(268) : warning C4431: missing type specifier - int assumed. Note: C no longer supports default-int
/src/ngx_http_encrypted_session_cipher.c(268) : error C2054: expected '(' to follow 'inline'
/src/ngx_http_encrypted_session_cipher.c(268) : error C2082: redefinition of formal parameter 'ngx_http_encrypted_session_htonll'
/src/ngx_http_encrypted_session_cipher.c(268) : error C2143: syntax error : missing ';' before '{'

agentzh

Hello!

On Fri, Feb 7, 2014 at 11:42 AM,  info wrote:
> Heya agentzh, hopefully you have a few minutes to fix these warnings :)
>

Attempted a fix in master:

    https://github.com/agentzh/encrypted-session-nginx-module/commit/ca19e95

Please try out the latest master on your side.

Thanks!
-agentzh

info

Attempted a fix in master:

https://github.com/agentzh/encrypted-session-nginx-module/commit/ca19e95

Please try out the latest master on your side.

Thanks!
-agentzh

That was quick :) 2 warnings left;

/src/ngx_http_encrypted_session_cipher.c(263) : warning C4244: 'function' : conversion from 'uint64_t' to 'u_long', possible loss of data
/src/ngx_http_encrypted_session_cipher.c(273) : warning C4244: 'function' : conversion from 'uint64_t' to 'u_long', possible loss of data

Thank you!

info

/src/ngx_http_encrypted_session_cipher.c(263) : warning C4244: 'function' : conversion from 'uint64_t' to 'u_long', possible loss of data
/src/ngx_http_encrypted_session_cipher.c(273) : warning C4244: 'function' : conversion from 'uint64_t' to 'u_long', possible loss of data

Found a solution I think, https://issues.apache.org/jira/browse/THRIFT-1666

So in ngx_http_encrypted_session_cipher.h
I added after line 26:

#if defined(_MSC_VER) /* Microsoft Visual C++ */
#define ntohll(n) ( _byteswap_uint64((uint64_t)n) )
#define htonll(n) ( _byteswap_uint64((uint64_t)n) )
#endif

Clean compile. Hopefully this is correct.