Experimental: Manipulate upstream config at runtime

femaref · 2014-04-15T18:34:05+00:00

Hello! On Sun, Apr 13, 2014 at 12:50 PM, Larry C wrote: > So the only thing to avoid is to load the sqlite binding directly in > nginx/openresty with...

Experimental: Manipulate upstream config at runtime

femaref

Hello,

I've been working on a module to manipulate the upstream config at runtime for the last few weeks.

Currently, it's more or less a proof of concept with limited features, but I'd like some comments, concerning functionality and especially code. If you have any ideas regarding functionality, I'll add them to the todo list.

Current features:

Query list of upstreams

Query single upstream

Add peers to an upstream

Bit more details in the README.

Code wise, I'm mostly interested in comments regarding the memory handling of internal nginx structs (e.g. ngx_http_flynx_data_add_peer_handler, ngx_http_flynx_upstream.c:35-110), but any other criticism is welcome as well, as this is effectively my first try at nginx module development.

Greetings, Femaref

Attachment: flynx.tar.gz
Description: Binary data

agentzh

Hello!

On Tue, Apr 15, 2014 at 3:34 AM, Femaref wrote:
> Current features:
>
> Query list of upstreams
> Query single upstream
> Add peers to an upstream
>

Is it possible to join the efforts in the ngx_lua_upstream module?

    https://github.com/agentzh/lua-upstream-nginx-module

Best regards,
-agentzh

femaref

Is it possible to join the efforts in the ngx_lua_upstream module?

I thought about it, but decided against it, as the query/manipulation functionality in the ngx_lua_upstream module is tightly coupled with the lua implementation. The module itself while serve further purposes, and the manipulation code will be extracted later; at which point I'm perfectly happy with supplementing the functionality in ngx_lua_upstream. I'm sorry for the overlapping scope.

Femaref