content_by_lua_file dynamic file look up?

skynare · 2014-07-10T00:36:33+00:00

Hello! On Wed, Jul 9, 2014 at 2:42 AM, Ruoshan Huang wrote: > if nginx receive HUP signal, and workers are restarted, what would > happen to the J...

content_by_lua_file dynamic file look up?

skynare

GET /scripts/foo/bar.lua

I want the above request to be handled by $NGINX/scripts/foo/bar.lua

I can add the following in nginx.conf

location /scripts/foo/bar.lua {

content_by_lua_file 'scripts/foo/bar.lua';
}

But I have many files under scripts directory. And, I want the following requests to be handled by respective lua files:

GET /scripts/a.lua

GET /scripts/b.lua
...

GET /scripts/a/b/c/d.lua
...

Almost like cgi-bin.

How can I make this possible?

agentzh

Hello!

On Wed, Jul 9, 2014 at 9:36 AM, Sam Lee wrote:
> GET /scripts/foo/bar.lua
> I want the above request to be handled by $NGINX/scripts/foo/bar.lua
> I can add the following in nginx.conf
>     location /scripts/foo/bar.lua {
>         content_by_lua_file 'scripts/foo/bar.lua';
>     }
> But I have many files under scripts directory. And, I want the following
> requests to be handled by respective lua files:
> GET /scripts/a.lua
> GET /scripts/b.lua
> ...
> GET /scripts/a/b/c/d.lua

Easy. Just use an nginx variable in content_by_lua. For instance,

    location ~ '^/scripts/((?:[-\w]+/)*[-\w+]+\.lua)$' {
        content_by_lua_file scripts/$1;
    }

The kinda complicated regex for the location is to protect against
injection attacks. So be careful here and prevent using overly
permissive simple path patterns like "(.*)".

Regards,
-agentzh

skynare

Thanks that works great!

Now, I want to send 404 instead of 500 when script isn't found.

For example,

GET /scripts/foobar.lua

and scripts/foobar.lua isn't found. Then nginx gives me 500.

I was looking for a way to turn this into 404 error https://github.com/openresty/lua-nginx-module/#content_by_lua_file but I don't think there's suitable option.

Is it better to have:

        location ~ '^/scripts/((?:[-\w]+/)*[-\w]+\.lua)$' {
            default_type text/html;
            content_by_lua_file 'scripts/main.lua'; // and pass $1 to this script and have it dispatch proper lua file or 404 if file is not found??
        }

On Wed, Jul 9, 2014 at 3:09 PM, Yichun Zhang (agentzh) <age...@gmail.com> wrote:

Hello!

On Wed, Jul 9, 2014 at 9:36 AM, Sam Lee wrote:
> GET /scripts/foo/bar.lua
> I want the above request to be handled by $NGINX/scripts/foo/bar.lua
> I can add the following in nginx.conf
> location /scripts/foo/bar.lua {
> content_by_lua_file 'scripts/foo/bar.lua';
> }
> But I have many files under scripts directory. And, I want the following
> requests to be handled by respective lua files:
> GET /scripts/a.lua
> GET /scripts/b.lua
> ...
> GET /scripts/a/b/c/d.lua

Easy. Just use an nginx variable in content_by_lua. For instance,

location ~ '^/scripts/((?:[-\w]+/)*[-\w+]+\.lua)$' {
content_by_lua_file scripts/$1;
}

The kinda complicated regex for the location is to protect against
injection attacks. So be careful here and prevent using overly
permissive simple path patterns like "(.*)".

Regards,
-agentzh
.

agentzh

Hello!

On Thu, Jul 10, 2014 at 7:15 AM, Sam Lee wrote:
> Thanks that works great!
>

Good to know :)

> Now, I want to send 404 instead of 500 when script isn't found.
> For example,
>     GET /scripts/foobar.lua
> and scripts/foobar.lua  isn't found. Then nginx gives me 500.
> I was looking for a way to turn this into 404 error

Okay, I agree this is a good thing to have and I've just committed a
patch to return 404 in case that the .lua file cannot be opened:

    https://github.com/openresty/lua-nginx-module/commit/0778f2b

Be careful that not only the "no such file or directory" error can
trigger 404 but also some other errors like lack of permissions.

Regards,
-agentzh