location.capture, ngx_proxy and X-Forwarded-For

hamish.forbes · 2014-09-23T21:59:39+00:00

I did this , it turned out to be that it failed to kill all nginx processes ,using the command sudo killall nginx in my Mac, I...

location.capture, ngx_proxy and X-Forwarded-For

hamish.forbes

Hi agentzh,

I think I've found a bug, or at least a behaviour change, relating to ngx.location.capture when combined with ngx_proxy and the X-Forwarded-For request header.

I'm not sure if this is something that changed in the nginx core or in ngx_lua.

I'm trying to use proxy_set_header to set a header to $http_x_forwarded_for (We're doing this due to the way out puppet/hiera config system works, I've got a workaround in place so its not urgent).

However when using ngx.location.capture the X-Forwarded-For header doesn't come through in the proxied endpoint.

If I request the proxy location directly, via ngx.exec, or via a vanilla nginx rewrite it works as expected.

It also works as expected with location.capture in Openresty 1.4.3.6 but not in the next release 1.5.12.1.

Using proxy_set_header and any other $http_* variable seems to work fine, its specific to X-Forwarded-For.

$proxy_add_x_forwarded_for and $http_x_real_ip also work.

Here's a minimal config to reproduce and the results: https://gist.github.com/hamishforbes/fab6ed71b4858455332a

Thanks!

Hamish

agentzh

Hello!

On Tue, Sep 23, 2014 at 6:59 AM, Hamish Forbes wrote:
> I think I've found a bug, or at least a behaviour change, relating to
> ngx.location.capture when combined with ngx_proxy and the X-Forwarded-For
> request header.
> I'm not sure if this is something that changed in the nginx core or in
> ngx_lua.
>
> I'm trying to use proxy_set_header to set a header to $http_x_forwarded_for
> (We're doing this due to the way out puppet/hiera config system works, I've
> got a workaround in place so its not urgent).
>

Thank you for the report! This is indeed an issue due to recent
changes in the nginx core.

I'll attempt a fix soon.

Thanks!
-agentzh

agentzh

Hello!

On Mon, Oct 13, 2014 at 2:49 PM, Yichun Zhang (agentzh) wrote:
> On Tue, Sep 23, 2014 at 6:59 AM, Hamish Forbes wrote:
>> I think I've found a bug, or at least a behaviour change, relating to
>> ngx.location.capture when combined with ngx_proxy and the X-Forwarded-For
>> request header.
>> I'm not sure if this is something that changed in the nginx core or in
>> ngx_lua.
>>
>> I'm trying to use proxy_set_header to set a header to $http_x_forwarded_for
>> (We're doing this due to the way out puppet/hiera config system works, I've
>> got a workaround in place so its not urgent).
>>
>
> Thank you for the report! This is indeed an issue due to recent
> changes in the nginx core.
>
> I'll attempt a fix soon.

I think it's already fixed in the latest version. Will you please
verify that with the latest OpenResty 1.9.7.1 RC2 release?

Thanks a lot and sorry for the long delay on my side.

Best regards,
-agentzh

hamish.forbes

Hi,

Yep, looks to be working in the latest release :)

Hamish

On Thursday, 24 December 2015 19:36:09 UTC, agentzh wrote:

Hello!

On Mon, Oct 13, 2014 at 2:49 PM, Yichun Zhang (agentzh) wrote:
> On Tue, Sep 23, 2014 at 6:59 AM, Hamish Forbes wrote:
>> I think I've found a bug, or at least a behaviour change, relating to
>> ngx.location.capture when combined with ngx_proxy and the X-Forwarded-For
>> request header.
>> I'm not sure if this is something that changed in the nginx core or in
>> ngx_lua.
>>
>> I'm trying to use proxy_set_header to set a header to $http_x_forwarded_for
>> (We're doing this due to the way out puppet/hiera config system works, I've
>> got a workaround in place so its not urgent).
>>
>
> Thank you for the report! This is indeed an issue due to recent
> changes in the nginx core.
>
> I'll attempt a fix soon.

I think it's already fixed in the latest version. Will you please
verify that with the latest OpenResty 1.9.7.1 RC2 release?

Thanks a lot and sorry for the long delay on my side.

Best regards,
-agentzh

hamish.forbes

Hi,

Yep, looks to be working in the latest release :)

Hamish

On Thursday, 24 December 2015 19:36:09 UTC, agentzh wrote:

Hello!

On Mon, Oct 13, 2014 at 2:49 PM, Yichun Zhang (agentzh) wrote:
> On Tue, Sep 23, 2014 at 6:59 AM, Hamish Forbes wrote:
>> I think I've found a bug, or at least a behaviour change, relating to
>> ngx.location.capture when combined with ngx_proxy and the X-Forwarded-For
>> request header.
>> I'm not sure if this is something that changed in the nginx core or in
>> ngx_lua.
>>
>> I'm trying to use proxy_set_header to set a header to $http_x_forwarded_for
>> (We're doing this due to the way out puppet/hiera config system works, I've
>> got a workaround in place so its not urgent).
>>
>
> Thank you for the report! This is indeed an issue due to recent
> changes in the nginx core.
>
> I'll attempt a fix soon.

I think it's already fixed in the latest version. Will you please
verify that with the latest OpenResty 1.9.7.1 RC2 release?

Thanks a lot and sorry for the long delay on my side.

Best regards,
-agentzh