HttpLuaModule - SPDY seems fully supported now?

kiprasm · 2015-01-28T18:25:55+00:00

Hello Shiva, i can not say much about how many keys are too much, but if I read "periodically dump log stats" statsd comes into my brain... What a...

HttpLuaModule - SPDY seems fully supported now?

kiprasm

Hi,

in the HttpLuaModule docs it is written that SPDY mode is not fully supported yet: http://wiki.nginx.org/HttpLuaModule#SPDY_Mode_Not_Fully_Supported
Specifically, that "ngx.location.capture()" does not work yet.

However, i ran some code that uses ngx.location.capture(), with SPDY and everything worked (both SPDY and the Lua code).

So is it possible that SPDY mode now works fully under ngx_lua, only the documentation is not updated?

nginx version: openresty/1.7.4.1

agentzh

Hello!

On Wed, Jan 28, 2015 at 2:25 AM, Kipras Mancevičius wrote:
> in the HttpLuaModule docs it is written that SPDY mode is not fully
> supported yet:
> http://wiki.nginx.org/HttpLuaModule#SPDY_Mode_Not_Fully_Supported
> Specifically, that "ngx.location.capture()" does not work yet.
>

Yes, it was reported broken.

> However, i ran some code that uses ngx.location.capture(), with SPDY and
> everything worked (both SPDY and the Lua code).
>

Will you try harder? If it's indeed working, I'll fix the documentation :)

> So is it possible that SPDY mode now works fully under ngx_lua, only the
> documentation is not updated?
>

It's certainly possible :) I don't use SPDY with ngx_lua myself so I
have no idea about the current status.

Thanks for the info!

Regards,
-agentzh

kiprasm

I did some more testing and looks like ngx.location.capture() and ngx.location.capture_multi() work without problems.

Trying to use ngx.req.socket() though gives this error: "spdy not supported yet"

So i guess that's the only thing still left unsupported.

On Wednesday, January 28, 2015 at 10:19:22 PM UTC+2, agentzh wrote:

Hello!

On Wed, Jan 28, 2015 at 2:25 AM, Kipras Mancevičius wrote:
> in the HttpLuaModule docs it is written that SPDY mode is not fully
> supported yet:
> http://wiki.nginx.org/HttpLuaModule#SPDY_Mode_Not_Fully_Supported
> Specifically, that "ngx.location.capture()" does not work yet.
>

Yes, it was reported broken.

> However, i ran some code that uses ngx.location.capture(), with SPDY and
> everything worked (both SPDY and the Lua code).
>

Will you try harder? If it's indeed working, I'll fix the documentation :)

> So is it possible that SPDY mode now works fully under ngx_lua, only the
> documentation is not updated?
>

It's certainly possible :) I don't use SPDY with ngx_lua myself so I
have no idea about the current status.

Thanks for the info!

Regards,
-agentzh

agentzh

Hello!

On Tue, Feb 3, 2015 at 8:00 AM, Kipras Mancevičius wrote:
> I did some more testing and looks like ngx.location.capture() and
> ngx.location.capture_multi() work without problems.

Thanks for the info!

Will you please try complicated ngx.location.capture_multi() on your
side as well?

> Trying to use ngx.req.socket() though gives this error: "spdy not supported
> yet"
> So i guess that's the only thing still left unsupported.
>

Yes, this part requires significant amount of work because the SPDY
module is (officially) a hack per se :)

Regards,
-agentzh

mat999

Would it be possible to unit test the capture api's in a SPDY environment?

I will do some testing myself next week.

agentzh

Hello!

On Tue, Feb 3, 2015 at 6:21 PM, Mathew Heard wrote:
> Would it be possible to unit test the capture api's in a SPDY environment?
>

It's certainly possible. It's just that SPDY is a complicated creature
and it will take me quite some time to prepare the scaffold for every
corner case. And I haven't found that much time for this work yet.

> I will do some testing myself next week.
>

Cool, thanks :)

Regards,
-agentzh