ngx.location.capture + mod_dav = puzzling

igor.clark · 2015-10-21T08:00:10+00:00

Hello! On Tue, Oct 20, 2015 at 4:25 AM, Miguel wrote: > I just started playing with OpenResty and Lua but If you need any help I can > try to spend so...

ngx.location.capture + mod_dav = puzzling

igor.clark

Hi folks,

My app uses WebDAV to manipulate files and directories by URL via the ngx_http_dav_module.

I have the appropriate dav_methods PUT, DELETE, MOVE set up in nginx.conf, and I call them in subrequests using ngx.location.capture().

For example, this code DELETEs a file or directory, successfully:

local rm_res = ngx.location.capture( delete_url, { method = ngx.HTTP_DELETE } )

Other parts of the app PUT and POST as well. All of that works fine.

I'm now trying to use MOVE. The DAV config works as expected:

$ telnet my-server 80

Connected to my-server.

Escape character is '^]'.

MOVE /my-url-1/ HTTP/1.1
Destination: /my-url-2/
Host: my-server

HTTP/1.1 201 Created
Server: openresty/1.9.3.1

Date: Tue, 20 Oct 2015 21:27:14 GMT
Content-Length: 0
Connection: keep-alive

But when I issue the MOVE request from lua:

local from_url, to_url = "/my-url-1/", "/my-url-2/"

ngx.req.set_header("Destination", to_url)
local mv_res = ngx.location.capture( from_url, { method = ngx.HTTP_MOVE } )

the request fails with a 400 Bad Request, and this shows up in the log:

2015/10/20 22:48:22 [error] 4515#0: *7 client sent no "Destination" header, client: 192.168.56.1, server: _, request: "POST /my-lua-handler HTTP/1.1", subrequest: "/my-url-1/", host: "my-server"

So I set up the url /echo thus, to test:

location = /echo {
content_by_lua '
ngx.header["Content-type"] = "text/plain"
ngx.say(ngx.req.get_headers()['Destination'])
'
}

and put this in /my-lua-handler

ngx.req.set_header("Destination", to_url)
local mv_res = ngx.location.capture( from_url, { method = ngx.HTTP_MOVE } )
ngx.say("dest: ", mv_res.body)

and what comes out is:

dest: /my-url-2/

Which is a bit baffling. I tried this with ngx.HTTP_GET as well as HTTP_MOVE, and the results are the same.

Am I doing something wrong, or maybe doing something dumb? Is there perhaps some interaction between ngx_lua and ngx_http_dav that I'm missing?

Thanks for any help,

Igor

agentzh

Hello!

On Wed, Oct 21, 2015 at 8:00 AM, Igor Clark wrote:
> But when I issue the MOVE request from lua:
>
> local from_url, to_url = "/my-url-1/", "/my-url-2/"
> ngx.req.set_header("Destination", to_url)
> local mv_res = ngx.location.capture( from_url, { method = ngx.HTTP_MOVE } )
>
> the request fails with a 400 Bad Request, and this shows up in the log:
>
> 2015/10/20 22:48:22 [error] 4515#0: *7 client sent no "Destination" header,
> client: 192.168.56.1, server: _, request: "POST /my-lua-handler HTTP/1.1",
> subrequest: "/my-url-1/", host: "my-server"

Thanks for the test case and report! Just fixed in the git master
branch of ngx_lua:

    https://github.com/openresty/lua-nginx-module/commit/b948841c0

Best regards,
-agentzh

igor.clark

Amazing. Thank you agentzh, that's perfect. I really appreciate it!

best,

Igor

On Wednesday, October 21, 2015 at 4:50:01 AM UTC+1, agentzh wrote:

Hello!

On Wed, Oct 21, 2015 at 8:00 AM, Igor Clark wrote:
> But when I issue the MOVE request from lua:
>
> local from_url, to_url = "/my-url-1/", "/my-url-2/"
> ngx.req.set_header("Destination", to_url)
> local mv_res = ngx.location.capture( from_url, { method = ngx.HTTP_MOVE } )
>
> the request fails with a 400 Bad Request, and this shows up in the log:
>
> 2015/10/20 22:48:22 [error] 4515#0: *7 client sent no "Destination" header,
> client: 192.168.56.1, server: _, request: "POST /my-lua-handler HTTP/1.1",
> subrequest: "/my-url-1/", host: "my-server"

Thanks for the test case and report! Just fixed in the git master
branch of ngx_lua:

https://github.com/openresty/lua-nginx-module/commit/b948841c0

Best regards,
-agentzh