accessing http_x_forwarded_proto?

tedt · 2015-12-22T13:23:04+00:00

Hello! On Mon, Dec 21, 2015 at 12:07 PM, RJoshi wrote: > got it. I thought by passing {} will send header Set-Cookie: "". No. Otherwise it wo...

accessing http_x_forwarded_proto?

tedt

I'm trying to do some work that depends on nginx's http_x_forwarded_proto, but it's always nil in access_by_lua (or access_by_lua_block). I've tried ngx.var.http_x_forwarded_proto and simplyhttp_x_forwarded_proto. Am I missing something? Is there a way to get at this field?

I'm on version 9.04, but I haven't seen anything in the github issues that imply that has been fixed.

agentzh

Hello!

On Mon, Dec 21, 2015 at 9:23 PM, Ted Timmons wrote:
> I'm trying to do some work that depends on nginx's http_x_forwarded_proto,
> but it's always nil in access_by_lua (or access_by_lua_block). I've tried
> ngx.var.http_x_forwarded_proto and simplyhttp_x_forwarded_proto. Am I
> missing something? Is there a way to get at this field?
>

Please provide a minimal and standalone example that we can run on our
side to easily reproduce the issue. Thank you.

> I'm on version 9.04, but I haven't seen anything in the github issues that
> imply that has been fixed.
>

I cannot interpret the version number 9.04. It does not look like
nginx core's version since the latest verison is 1.9.x and it does not
look like the ngx_lua module's version since the latest one is 0.9.20.
It does not look like the OpenResty bundle's version since the latest
one is 1.9.3.2 (and 1.9.7.1 RC1). So what does it mean? Some operating
system's version? Will you be a bit more careful and explicit?

Regards,
-agentzh

ted

On Mon, Dec 21, 2015 at 9:26 PM Yichun Zhang (agentzh) <age...@gmail.com> wrote:

On Mon, Dec 21, 2015 at 9:23 PM, Ted Timmons wrote:
> I'm trying to do some work that depends on nginx's http_x_forwarded_proto,
> but it's always nil in access_by_lua (or access_by_lua_block). I've tried
> ngx.var.http_x_forwarded_proto and simplyhttp_x_forwarded_proto. Am I
> missing something? Is there a way to get at this field?
>

Please provide a minimal and standalone example that we can run on our
side to easily reproduce the issue. Thank you.

Here's an example:

access_by_lua '
if not ngx.var.http_x_forwarded_proto == nil then

ngx.log(ngx.ERR, "time to redirect.")
ngx.redirect("https://" .. ngx.var.host, ngx.HTTP_MOVED_PERMANENTLY)
end
';

I'm testing it with this:

curl -H "x-forwarded-proto: https" -D - http://localhost/

Expected output is a Location header and an error.log entry. I see neither.

> I'm on version 9.04, but I haven't seen anything in the github issues that
> imply that has been fixed.
>

I cannot interpret the version number 9.04. It does not look like
nginx core's version since the latest verison is 1.9.x and it does not
look like the ngx_lua module's version since the latest one is 0.9.20.

Sorry, I mean 0.9.4, or 0.9.04, I don't know how the numbering was done. I was using ngx.config.ngx_lua_version to verify, which gave 9004.

irt_m.jrsyo

Hi Ted,

Quick reply.

http header is case insensitive.

So, you should use 'X-Forwarded-Proto' not 'x-forwarded-proto'.

access_by_lua '

if ngx.var.http_x_forwarded_proto == "http" then

ngx.log(ngx.ERR, "time to redirect.")
ngx.redirect("https://" .. ngx.var.host .. ngx.var.request_uri, ngx.HTTP_MOVED_PERMANENTLY)
end
';

2015年12月22日火曜日 14時39分06秒 UTC+9 Ted Timmons:

On Mon, Dec 21, 2015 at 9:26 PM Yichun Zhang (agentzh) <age...@gmail.com> wrote:
On Mon, Dec 21, 2015 at 9:23 PM, Ted Timmons wrote:
> I'm trying to do some work that depends on nginx's http_x_forwarded_proto,
> but it's always nil in access_by_lua (or access_by_lua_block). I've tried
> ngx.var.http_x_forwarded_proto and simplyhttp_x_forwarded_proto. Am I
> missing something? Is there a way to get at this field?
>

Please provide a minimal and standalone example that we can run on our
side to easily reproduce the issue. Thank you.

Here's an example:

access_by_lua '
if not ngx.var.http_x_forwarded_proto == nil then
ngx.log(ngx.ERR, "time to redirect.")
ngx.redirect("https://" .. ngx.var.host, ngx.HTTP_MOVED_PERMANENTLY)
end
';
I'm testing it with this:

curl -H "x-forwarded-proto: https" -D - http://localhost/
Expected output is a Location header and an error.log entry. I see neither.

> I'm on version 9.04, but I haven't seen anything in the github issues that
> imply that has been fixed.
>

I cannot interpret the version number 9.04. It does not look like
nginx core's version since the latest verison is 1.9.x and it does not
look like the ngx_lua module's version since the latest one is 0.9.20.

Sorry, I mean 0.9.4, or 0.9.04, I don't know how the numbering was done. I was using ngx.config.ngx_lua_version to verify, which gave 9004.

ted

On Mon, Dec 21, 2015 at 10:42 PM <irt_m...@ntworkers.com> wrote:

Hi Ted,

Quick reply.
http header is case insensitive.
So, you should use 'X-Forwarded-Proto' not 'x-forwarded-proto'.

> if ngx.var.http_x_forwarded_proto == "http" then

I'm not sure if you mean case sensitive or case insensitive? Changing the header to X-Forwarded-Proto fixed it for me though- and the correct test made it much faster to get to the correct code. Thanks!

agentzh

Hello!

On Mon, Dec 21, 2015 at 9:38 PM, Ted Timmons wrote:
> Here's an example:
>
> access_by_lua '
>   if not ngx.var.http_x_forwarded_proto == nil then
>     ngx.log(ngx.ERR, "time to redirect.")
>     ngx.redirect("https://"; .. ngx.var.host, ngx.HTTP_MOVED_PERMANENTLY)
>   end
> ';
>
> I'm testing it with this:
>
> curl -H "x-forwarded-proto: https" -D - http://localhost/
>
> Expected output is a Location header and an error.log entry. I see neither.

I've tried your code example locally with the following self-contained
configuration:

    location = /t {
        access_by_lua_block {
            local v = ngx.var.http_x_forwarded_proto
            if v == nil then
                ngx.log(ngx.ERR, "time to redirect.")
                return ngx.redirect("https://"; .. ngx.var.host ..
ngx.var.request_uri,
                                    ngx.HTTP_MOVED_PERMANENTLY)
            end
        }

        echo ok;
    }

And then test it out with your request:

    $ curl -H "x-forwarded-proto: https" -i http://localhost:8080/t
    HTTP/1.1 200 OK
    Server: nginx/1.9.7 (no pool)
    Date: Tue, 22 Dec 2015 18:14:07 GMT
    Content-Type: text/plain
    Transfer-Encoding: chunked
    Connection: keep-alive

    ok

    $ grep "\[error" t/servroot/logs/error.log

    $ curl -H "X-Forwarded-Proto: https" -i http://localhost:8080/t
    HTTP/1.1 200 OK
    Server: nginx/1.9.7 (no pool)
    Date: Tue, 22 Dec 2015 18:14:45 GMT
    Content-Type: text/plain
    Transfer-Encoding: chunked
    Connection: keep-alive

    ok

    $ grep "\[error" t/servroot/logs/error.log

    $ curl -i http://localhost:8080/t
    HTTP/1.1 301 Moved Permanently
    Server: nginx/1.9.7 (no pool)
    Date: Tue, 22 Dec 2015 18:15:11 GMT
    Content-Type: text/html
    Content-Length: 194
    Connection: keep-alive
    Location: https://localhost/t

    <html>
    <head><title>301 Moved Permanently</title></head>
    <body bgcolor="white">
    <center><h1>301 Moved Permanently</h1></center>
    <hr><center>nginx/1.9.7 (no pool)</center>
    </body>
    </html>

    $ grep "\[error" t/servroot/logs/error.log
    2015/12/22 10:15:11 [error] 120299#0: *3 [lua]
access_by_lua(nginx.conf:47):4: time to redirect., client: 127.0.0.1,
server: localhost, request: "GET /t HTTP/1.1", host: "localhost:8080"

So these are all what you'd expect? When there is no X-Forwarded-Proto
request headers, you initiate a 301 redirect, according to your Lua
code logic. And we can also see that HTTP header names are
case-insensitive. How should I reproduce the problem you have?

Best regards,
-agentzh