Unable to get test with '--- must_die' to pass

jon.keys · 2016-03-21T13:29:09+00:00

Hi agentzh! Sure, sorry - don't know why I didn't think to do that. Duh. Here it is: https://github.com/openresty/lua-nginx-module/issues/724 Thanks! che...

Unable to get test with '--- must_die' to pass

jon.keys

I'm not sure what I'm doing wrong but I can't get even the simplest test to pass.

Env:

OpenResty 1.9.7.4

CentOS 7

Test case:

use Test::Nginx::Socket 'no_plan';

run_tests();

__DATA__

=== TEST 1: boom
--- http_config
    init_by_lua_block {
        error('boom')
    }
--- config
--- must_die
--- error_log
boom

Result:

t/boom.t .. nginx: [error] init_by_lua error: init_by_lua:2: boom
stack traceback:
	[C]: in function 'error'
	init_by_lua:2: in main chunk
t/boom.t .. 1/?
#   Failed test 'TEST 1: boom - pattern "boom" should match a line in error.log (req 0)'
#   at /usr/local/share/perl5/Test/Nginx/Socket.pm line 1102.
# Looks like you failed 1 test of 2.
t/boom.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests

Test Summary Report
-------------------
t/boom.t (Wstat: 256 Tests: 2 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=2,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.08 cusr  0.02 csys =  0.12 CPU)
Result: FAIL

Any idea what I might be doing wrong here?

rpaprocki

logs at error level in the init phase are written to std out, as we can see in the output you provided. The error_log test directive will search the log file at t/serverroot/logs/error.log. Since the error() directive in your init config does not write to the error log, the test fails. For this particular test, may i suggest you create a simple ---config directive with a location block, a *by_lua handler for access/rewrite/content/etc, and a corresponding ---request definition. From this context error() calls will indeed make it to the log file. Hth!

On Mar 20, 2016, at 22:29, Jon Keys <jon...@gmail.com> wrote:

I'm not sure what I'm doing wrong but I can't get even the simplest test to pass.

Env:
OpenResty 1.9.7.4
CentOS 7

Test case:
use Test::Nginx::Socket 'no_plan'; run_tests(); __DATA__ === TEST 1: boom --- http_config init_by_lua_block { error('boom') } --- config --- must_die --- error_log boom

Result:
t/boom.t .. nginx: [error] init_by_lua error: init_by_lua:2: boom stack traceback: [C]: in function 'error' init_by_lua:2: in main chunk t/boom.t .. 1/? # Failed test 'TEST 1: boom - pattern "boom" should match a line in error.log (req 0)' # at /usr/local/share/perl5/Test/Nginx/Socket.pm line 1102. # Looks like you failed 1 test of 2. t/boom.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Test Summary Report ------------------- t/boom.t (Wstat: 256 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=2, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.08 cusr 0.02 csys = 0.12 CPU) Result: FAIL

Any idea what I might be doing wrong here?

.

jon.keys

Thanks for your response. It makes sense to me but the testing docs seem to suggest otherwise.

I was hoping to directly test the code running in `init_by_lua_*` without relying on other mechanisms which could introduce their own behavior. I can live with a workaround -- I just wanted to be sure I wasn't missing something obvious.

Thanks again!

On Monday, March 21, 2016 at 10:15:39 AM UTC-4, rpaprocki wrote:

logs at error level in the init phase are written to std out, as we can see in the output you provided. The error_log test directive will search the log file at t/serverroot/logs/error.log. Since the error() directive in your init config does not write to the error log, the test fails. For this particular test, may i suggest you create a simple ---config directive with a location block, a *by_lua handler for access/rewrite/content/etc, and a corresponding ---request definition. From this context error() calls will indeed make it to the log file. Hth!

On Mar 20, 2016, at 22:29, Jon Keys <jon....@gmail.com> wrote:

I'm not sure what I'm doing wrong but I can't get even the simplest test to pass.

Env:
OpenResty 1.9.7.4
CentOS 7

Test case:
use Test::Nginx::Socket 'no_plan'; run_tests(); __DATA__ === TEST 1: boom --- http_config init_by_lua_block { error('boom') } --- config --- must_die --- error_log boom

Result:
t/boom.t .. nginx: [error] init_by_lua error: init_by_lua:2: boom stack traceback: [C]: in function 'error' init_by_lua:2: in main chunk t/boom.t .. 1/? # Failed test 'TEST 1: boom - pattern "boom" should match a line in error.log (req 0)' # at /usr/local/share/perl5/Test/Nginx/Socket.pm line 1102. # Looks like you failed 1 test of 2. t/boom.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Test Summary Report ------------------- t/boom.t (Wstat: 256 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=2, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.08 cusr 0.02 csys = 0.12 CPU) Result: FAIL

Any idea what I might be doing wrong here?

.

rpaprocki

I will admit I haven't used ---must_die before, and I glanced over it in my initial response. Based on reading the docs it does indeed look like it's not performing as expected, especially given that it looks like you essentially copied the documented example. Perhaps another pair of eyes is necessary here?

On Mar 21, 2016, at 07:30, Jon Keys <jon...@gmail.com> wrote:

Thanks for your response. It makes sense to me but the testing docs seem to suggest otherwise.
I was hoping to directly test the code running in `init_by_lua_*` without relying on other mechanisms which could introduce their own behavior. I can live with a workaround -- I just wanted to be sure I wasn't missing something obvious.

Thanks again!

On Monday, March 21, 2016 at 10:15:39 AM UTC-4, rpaprocki wrote:
logs at error level in the init phase are written to std out, as we can see in the output you provided. The error_log test directive will search the log file at t/serverroot/logs/error.log. Since the error() directive in your init config does not write to the error log, the test fails. For this particular test, may i suggest you create a simple ---config directive with a location block, a *by_lua handler for access/rewrite/content/etc, and a corresponding ---request definition. From this context error() calls will indeed make it to the log file. Hth!

On Mar 20, 2016, at 22:29, Jon Keys <jon....@gmail.com> wrote:

I'm not sure what I'm doing wrong but I can't get even the simplest test to pass.

Env:
OpenResty 1.9.7.4
CentOS 7

Test case:
use Test::Nginx::Socket 'no_plan'; run_tests(); __DATA__ === TEST 1: boom --- http_config init_by_lua_block { error('boom') } --- config --- must_die --- error_log boom

Result:
t/boom.t .. nginx: [error] init_by_lua error: init_by_lua:2: boom stack traceback: [C]: in function 'error' init_by_lua:2: in main chunk t/boom.t .. 1/? # Failed test 'TEST 1: boom - pattern "boom" should match a line in error.log (req 0)' # at /usr/local/share/perl5/Test/Nginx/Socket.pm line 1102. # Looks like you failed 1 test of 2. t/boom.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Test Summary Report ------------------- t/boom.t (Wstat: 256 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=2, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.08 cusr 0.02 csys = 0.12 CPU) Result: FAIL

Any idea what I might be doing wrong here?

.

agentzh

Hello!

On Sun, Mar 20, 2016 at 10:29 PM, Jon Keys wrote:
> === TEST 1: boom
> --- http_config
>     init_by_lua_block {
>         error('boom')
>     }
> --- config
> --- must_die
> --- error_log
> boom
>

Your test file passes successfully on my side:

t/foo.t .. nginx: [error] init_by_lua error: init_by_lua:2: boom
stack traceback:
[C]: in function 'error'
init_by_lua:2: in main chunk
t/foo.t .. ok
All tests successful.
Files=1, Tests=2,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.10 cusr
0.03 csys =  0.14 CPU)
Result: PASS

> t/boom.t .. 1/?
> #   Failed test 'TEST 1: boom - pattern "boom" should match a line in
> error.log (req 0)'
> #   at /usr/local/share/perl5/Test/Nginx/Socket.pm line 1102.

Maybe your Test::Nginx installation is too old? Try upgrade it:

     sudo cpan Test::Nginx

BTW, you can find quite some test cases using "--- must_die" in
OpenResty's test suite.

Regards,
-agentzh

jon.keys

On Thursday, March 24, 2016 at 3:31:03 PM UTC-4, agentzh wrote:

Hello!

On Sun, Mar 20, 2016 at 10:29 PM, Jon Keys wrote:
> === TEST 1: boom
> --- http_config
> init_by_lua_block {
> error('boom')
> }
> --- config
> --- must_die
> --- error_log
> boom
>

Your test file passes successfully on my side:

t/foo.t .. nginx: [error] init_by_lua error: init_by_lua:2: boom
stack traceback:
[C]: in function 'error'
init_by_lua:2: in main chunk
t/foo.t .. ok
All tests successful.
Files=1, Tests=2, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.10 cusr
0.03 csys = 0.14 CPU)
Result: PASS

> t/boom.t .. 1/?
> # Failed test 'TEST 1: boom - pattern "boom" should match a line in
> error.log (req 0)'
> # at /usr/local/share/perl5/Test/Nginx/Socket.pm line 1102.

Maybe your Test::Nginx installation is too old? Try upgrade it:

sudo cpan Test::Nginx

The result of that command is: `Test::Nginx is up to date. (0.25)`

For me, this really isn't too big of an issue. I just wanted to be sure I wasn't doing something obviously wrong.

It must be something strange in my environment. I've built my test environment using docker / CentOS 7. I could post the Dockerfile if you like?

BTW, you can find quite some test cases using "--- must_die" in
OpenResty's test suite.

Yes, I saw some examples there but I did not attempt to run those tests myself. I'll try it this evening and see if I get any different results.

Thanks (as always) for your assistance!

- Jon