The unittest failed when 'got' is the same as 'expected'

hrpenf · 2016-06-20T11:12:52+00:00

Hello! On Fri, Jun 17, 2016 at 1:32 PM, Matthieu Labour wrote: > I am seeing the following traffic on SERVER > > ubuntu@ip-192-168-10-131:~$ while...

The unittest failed when 'got' is the same as 'expected'

hrpenf

I do some development for this in todo list: use ngx_hash_t to optimize the built-in header look-up process for ngx.req.set_header, ngx.header.HEADER, and etc.

when I run the unittest, I got this error which I think should be OK.

# prove -I/opt/openresty/test-nginx/lib t/111-req-header-ua.t

t/111-req-header-ua.t .. 1/144

# Failed test 'TEST 1: clear Opera user-agent - response_body - response is expected (repeated req 0, req 0)'

# at /opt/openresty/test-nginx/lib/Test/Nginx/Socket.pm line 1277.

# got: 'User-Agent:

# '

# expected: 'User-Agent:

# '

# Failed test 'TEST 1: clear Opera user-agent - response_body - response is expected (repeated req 1, req 0)'

# at /opt/openresty/test-nginx/lib/Test/Nginx/Socket.pm line 1277.

# got: 'User-Agent:

# '

# expected: 'User-Agent:

# '

t/111-req-header-ua.t .. 20/144

.....

t/111-req-header-ua.t .. 136/144 # Looks like you failed 18 tests of 144.

t/111-req-header-ua.t .. Dubious, test returned 18 (wstat 4608, 0x1200)

Failed 18/144 subtests

(less 36 skipped subtests: 90 okay)

james_9172

Your "got" has trailing white space but your "expected" does not.

On 20 June 2016 at 04:12, rako9000 <hr...@gmail.com> wrote:

I do some development for this in todo list: use ngx_hash_t to optimize the built-in header look-up process for ngx.req.set_header, ngx.header.HEADER, and etc.

when I run the unittest, I got this error which I think should be OK.

# prove -I/opt/openresty/test-nginx/lib t/111-req-header-ua.t
t/111-req-header-ua.t .. 1/144
# Failed test 'TEST 1: clear Opera user-agent - response_body - response is expected (repeated req 0, req 0)'
# at /opt/openresty/test-nginx/lib/Test/Nginx/Socket.pm line 1277.
# got: 'User-Agent:
# '
# expected: 'User-Agent:
# '

# Failed test 'TEST 1: clear Opera user-agent - response_body - response is expected (repeated req 1, req 0)'
# at /opt/openresty/test-nginx/lib/Test/Nginx/Socket.pm line 1277.
# got: 'User-Agent:
# '
# expected: 'User-Agent:
# '
t/111-req-header-ua.t .. 20/144
.....
.....
t/111-req-header-ua.t .. 136/144 # Looks like you failed 18 tests of 144.
t/111-req-header-ua.t .. Dubious, test returned 18 (wstat 4608, 0x1200)
Failed 18/144 subtests
(less 36 skipped subtests: 90 okay)

.

James Hurst

ja...@pintsized.co.uk

hrpenf

OK, thank you. The problem is my vim's config. My vim will remove trailing space automatically.

On Tue, Jun 21, 2016 at 12:23 AM, James Hurst <ja...@pintsized.co.uk> wrote:

Your "got" has trailing white space but your "expected" does not.

On 20 June 2016 at 04:12, rako9000 <hr...@gmail.com> wrote:
I do some development for this in todo list: use ngx_hash_t to optimize the built-in header look-up process for ngx.req.set_header, ngx.header.HEADER, and etc.

when I run the unittest, I got this error which I think should be OK.

# prove -I/opt/openresty/test-nginx/lib t/111-req-header-ua.t
t/111-req-header-ua.t .. 1/144
# Failed test 'TEST 1: clear Opera user-agent - response_body - response is expected (repeated req 0, req 0)'
# at /opt/openresty/test-nginx/lib/Test/Nginx/Socket.pm line 1277.
# got: 'User-Agent:
# '
# expected: 'User-Agent:
# '

# Failed test 'TEST 1: clear Opera user-agent - response_body - response is expected (repeated req 1, req 0)'
# at /opt/openresty/test-nginx/lib/Test/Nginx/Socket.pm line 1277.
# got: 'User-Agent:
# '
# expected: 'User-Agent:
# '
t/111-req-header-ua.t .. 20/144
.....
.....
t/111-req-header-ua.t .. 136/144 # Looks like you failed 18 tests of 144.
t/111-req-header-ua.t .. Dubious, test returned 18 (wstat 4608, 0x1200)
Failed 18/144 subtests
(less 36 skipped subtests: 90 okay)

.